Merged
Conversation
…prevent them from being out of scope in the event task when the condition.wait returns early due to a shutdown
Contributor
|
Intrigued by this! |
Contributor
|
@lo-simon was this the only dangling reference found in |
Collaborator
Author
It was fixed before, but somehow it clipped back in after the last merge. And yes, I am not detecting any more possibly dangling references to a temporary warning. |
| }); | ||
| request.then([&] | ||
| { | ||
| condition.notify_all(); |
Contributor
There was a problem hiding this comment.
What prompted the change from condition.notify_all() to model.notify()?
Collaborator
Author
There was a problem hiding this comment.
The notification code has been moved into the task.next chain. By using model.notify(), the condition.notify_all() wrapper adheres to the same style as in the other behavior threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the lambda capture to copy id_type and event_type by value to prevent them from being out of scope in the event task when the condition.wait returns early due to a shutdown.
Thank you to Paul Prayle from Sony for reporting the issue.